On Nov 11, 2008 19:43 -0800, Valerie Aurora Henson wrote: > - count = fs->super->s_blocks_count; > + count = ext2fs_blocks_count(fs->super); Along with changes like this (and the similar ACL fix) I'd prefer that we rename the old superblock field to be "s_block_count_lo" and put a comment there referencing the accessor functions so that compilation will fail and it is clear what needs to be fixed. As you can see from this patch, even though ext2fs_blocks_count() predates the 64-bit patches, it isn't used very widely. Landing other patches to e2fsprogs may run the risk of only accessing the low 32 bits of the size/count/acl/etc because they were developed before 64-bit support was added. Since it isn't yet common to be able to test > 32-bit blocks these bugs may go unnoticed for some time. It would be nice to be able to test 64-bit support easily with e2fsprogs. Maybe truncate file to > 16TB in size (abort if underlying filesystem isn't able to do this), use "lazy_bg" or equivalent to avoid writing many GB of data into the sparse file, then run e2fsck on it after putting some files at the end. This could probably be done by the "script" support in "make check". Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
