Per discussion on IRC, we've Aneesh and I have concluded that the V1 patch is correct, and in fact calling block_commit_write() when we will be redirtying the page (a) can cause problems if one or more buffer heads on the page is marked for delayed allocation and so bh->block_nr is 0, and (b) wastes disk bandwidth since the page contents will be potentially written out twice. So we'll be going with the V1 version of the patch, and pushing it to Linus ASAP. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html