On Fri, Nov 07, 2008 at 12:19:26AM +0530, Aneesh Kumar K.V wrote:
> #define EXT4_HAS_COMPAT_FEATURE(sb,mask) \
> - (EXT4_SB(sb)->s_es->s_feature_compat & cpu_to_le32(mask))
> + (le32_to_cpu(EXT4_SB(sb)->s_es->s_feature_compat) & mask)
> #define EXT4_HAS_RO_COMPAT_FEATURE(sb,mask) \
> - (EXT4_SB(sb)->s_es->s_feature_ro_compat & cpu_to_le32(mask))
> + (le32_to_cpu(EXT4_SB(sb)->s_es->s_feature_ro_compat) & mask)
> #define EXT4_HAS_INCOMPAT_FEATURE(sb,mask) \
> - (EXT4_SB(sb)->s_es->s_feature_incompat & cpu_to_le32(mask))
> + (le32_to_cpu(EXT4_SB(sb)->s_es->s_feature_incompat) & mask)
This is going to force a byte-swap instruction on every single
big-endian system out there, which could potentially be costly, or at
least undeed given that all of the times that these functions are
called, the result gets used only as a booelan.
Can we shut up sparse by using a explicit cast to an unsigned int?
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
