On Mon, Nov 03, 2008 at 01:48:40PM -0800, Arthur Jones wrote: > > - should we clear s_dirt if log_wait_commit() didn't work? > > > > - ext3_force_commit() clears s_dirt also > > I'm not sure if it makes sense, but ATM I don't think it > hurts anything given that ext3_write_super is just sb->s_dirt = 0; I want to look at this some more, but it's possible we should just remove all of the references to sb->s_dirt completely. Also, the comment just above ext[34]_write_super() is out of date since before 2.6.0. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html