On Fri, Oct 24, 2008 at 12:04:25PM +0530, Aneesh Kumar K.V wrote: > With this change new blocks added during resize > are marked as free in the block bitmap and the > group is flagged with EXT4_GROUP_INFO_NEED_INIT_BIT > flag. This make sure when mballoc tries to allocate > blocks from the new group we would reload the > buddy information using the bitmap present in the disk. Stupid question --- instead of reworking ext4_free_blocks_sb() and renaming it be to called ext4_add_groupblocks(), and then forcing mballoc() to reinitialize the block group, why not just have the resize code call ext4_mb_free_blocks()? Also I had to make some minor changes to patches 2 and 3 to make them apply against the latest tree (checked into the patch queue tree). I also changed calls to ext4_error() to use __func__ so the function name in used in ext4_add_groupblocks() was correct in patch #1 --- but I suspect that once you change resize to use ext4_mb_free_blocks(), ext4_add_groupblocks()/ext4_free_blocks_sb() can go away entirely. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
