Akira, can you please comment on these issues before going on? I think the generation issue is a particularly important one if you want to allow defrag by normal users. On Sun, Oct 26, 2008 at 04:48:48AM -0400, Christoph Hellwig wrote: > On Sun, Oct 26, 2008 at 02:40:48AM -0600, Andreas Dilger wrote: > > This was mentioned last time these patches were posted, but there was > > no reply from you. Christoph suggested a more generic VFS open-by-inum, > > which isn't impossible to do but would cause a lot of controversy I > > think, while the EXT4_IOC_WRAPPER is at least contained within ext4, > > but is more generically useful than EXT4_IOC_FIEMAP_INO. > > I'll hack up a generic open_by_handle and then we can gather the > reaction - it shouldn't be more than about one or two hundred lines of > code. Note that you really want an open by handle and not just inum for > a defragmentation tool - without the generation you can easily run into > races. > > Btw, any reason the XFS approach of passing in *file descriptors* for both > the inode to be defragmented and the "donor" inode doesn't work for you? -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
