Re: Unusual code in mballoc.c.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Rusty Russell wrote:
> Hi all,
> 
>    A grep lead me to fs/ext4/mballoc.c:
> 
> Line 2551:
> 	for (i = 0; i < nr_cpu_ids; i++) {
> 
> This is more normally "for_each_possible_cpu(i)".
> 
> Line 4097:
> 	ac->ac_lg = &sbi->s_locality_groups[get_cpu()];
> 	put_cpu();
> 
> This is presumably someone suppressing a warning.   It should be:
> 	ac->ac_lg = &sbi->s_locality_groups[raw_smp_processor_id()];
> 
> Thanks,
> Rusty.

Hi Rusty - I sent a patch for this a while back...

http://repo.or.cz/w/ext4-patch-queue.git?a=blob;f=ext4-use-percpu-data-for-lg_prealloc_list;h=8ddebb7f6054f70e34b142d7ae6f314d6629aac7;hb=HEAD

Thanks,
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux