On Sun, Sep 21, 2008 at 07:33:28PM +0200, Jan Kara wrote: > > This fixes some very common warnings reported by kerneloops.org > > > > Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx> > The patch looks nice but does it really fix the warnings? I see > at least ext3_put_super() calling mark_buffer_dirty() before calling > ext3_commit_super(). We should just remove that mark_buffer_dirty() > call. I tested it, and in practice it works, since mark_buffer_dirty() only causes a problem if an attempt to write to the superblock has already failed. I agree that we should just remove that mark_buffer_dirty() call, though, since ext3_put_super() calls ext3_commit_super() which calls mark_buffer_dirty() anyway. I'll respin the patch. > BTW: Do you plan doing a similar fix for ext2 and ext4? I have a similar fix for ext4 that is queued up to be pushed once the merge window opens. I haven't back-ported it to ext2 yet, but I will. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
