On Sun, Sep 14, 2008 at 02:18:59PM -0700, Eric Sandeen wrote: > The journal_checksum option is not being displayed in > /proc/mounts ... add this to the show_options() output, but > only if journal_async_commit is not specified, as that enables > journal_checksum internally. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Acked-by: "Theodore Ts'o" <tytso@xxxxxxx> I'll add it to the patch queue, probably combined with a patch to add journal_sync_commit, and with a patch to make journal_async_commit the default. > (Aside: this reminds me that we only show non-default options > in show_options; has there been any discussion of whether > these should be defaults?) Good point, thanks for raising the question. The reason why journal_async_commit wasn't turned on by default originally was because e2fsck didn't have support for journal checksums before e2fsprogs 1.41.0. At this point, it seems like turning on async_commit is the obvious (and performant) thing to do; any objections? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
