On Sat, Sep 13, 2008 at 11:32 PM, Theodore Ts'o <tytso@xxxxxxx> wrote: [...] > Eend: > - p = (ext2_dirent *)(kaddr + offs); > - ext2_error (sb, "ext2_check_page", > - "entry in directory #%lu spans the page boundary" > - "offset=%lu, inode=%lu", > - dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs, > - (unsigned long) le32_to_cpu(p->inode)); > + if (!quiet) { > + p = (ext2_dirent *)(kaddr + offs); > + ext2_error (sb, "ext2_check_page", ^^^^^^^^^^^^^^^^^^ > + "entry in directory #%lu spans the page boundary" > + "offset=%lu, inode=%lu", > + dir->i_ino, (page->index<<PAGE_CACHE_SHIFT)+offs, > + (unsigned long) le32_to_cpu(p->inode)); Minor issue. Since you are already changing "ext2_check_page" to __func__, you might as well change it here too. Thanks, Eugene -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html