On Sep 15, 2008 14:03 +0200, Karel Zak wrote: > Note that this patch also fix minor coding still errors. > > @@ -150,7 +150,7 @@ static void get_ext2_info(blkid_dev dev, struct blkid_magic *id, > > set_uuid(dev, es->s_uuid, 0); > > - if ((es->s_feature_compat & EXT3_FEATURE_COMPAT_HAS_JOURNAL) && > + if ((blkid_le32(es->s_feature_compat) & EXT3_FEATURE_COMPAT_HAS_JOURNAL) && Minor note - it is generally preferable to swab the constant value, since this can be done at compile time instead of runtime. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
