On Sep 12, 2008 14:57 +0530, Aneesh Kumar wrote: > On Fri, Sep 12, 2008 at 03:17:13AM -0600, Andreas Dilger wrote: > > Why not just try to set this flag and let the kernel decide what is > > possible? > > The motivation is to give a clear message that we still don't support > clearing extent flags. If we pass it to the kernel we will get > operation not supported error which would confuse the user who does > chattr -de f1 The problem is that if the kernel ever does allow converting extents-> block-mapped (or some other mapping that isn't extents), the chattr tool will cause this to fail even when it shouldn't. Better to leave the check in a single place (the kernel, which knows best). I don't think the user would be too confused. You could still check after the call to the kernel to see if the "e" option is being removed and print an error if the call failed. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
