Hidehiro Kawai wrote: > If we failed to write metadata buffers to the journal space and > succeeded to write the commit record, stale data can be written > back to the filesystem as metadata in the recovery phase. > > To avoid this, when we failed to write out metadata buffers, > abort the journal before writing the commit record. > > Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@xxxxxxxxxxx> > Acked-by: Jan Kara <jack@xxxxxxx> > --- > fs/jbd/commit.c | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux-2.6.26-rc8-mm1/fs/jbd/commit.c > =================================================================== > --- linux-2.6.26-rc8-mm1.orig/fs/jbd/commit.c > +++ linux-2.6.26-rc8-mm1/fs/jbd/commit.c > @@ -762,6 +762,9 @@ wait_for_iobuf: > /* AKPM: bforget here */ > } > > + if (err) > + journal_abort(journal, err); > + > jbd_debug(3, "JBD: commit phase 6\n"); > > if (journal_write_commit_record(journal, commit_transaction)) A little late for me to chime in, but why is this a journal_abort() when journal aborts before and after this call __journal_abort_hard()? I'm just not sure what's different about this one condition that we wish to update the error and the superblock here? Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
