On Sun, Sep 07, 2008 at 12:24:47PM -0400, Theodore Tso wrote: > On Sun, Sep 07, 2008 at 04:15:57PM +0400, Alexey Dobriyan wrote: > > > Why not use strchr(), which is normally optimized assembly: > > > > > > char *p = devname; > > > while ((p = strchr(p, '/')) > > > *p = '_'; > > > > > > Using '!' as the separator makes it harder to use from shells I suspect, > > > so I'd suggest '_' instead. > > > > bdevname is only 32 bytes and done once per mount, so nobody cares. > > Bloat gets inserted into the kernel, 32 bytes at a time. :-) You mean, one filesystem at time. ;-) > > '!' is what other code does in this situation (reiserfs, md, ...). > > I'm not convinced that the consistency is as important in this case as > making it easy for people using shells typing the pathname... A what? mkdir z\!ext4 ls z[Tab]\!ext4 As for underscore, use '-' if you really care about typing. One Shift less. register_disk() uses '!' too, BTW. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
