Small change to the ext4 journal credits reservation patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mingming,

FYI, I checked in a minor change to the ext4 journal credits reservation
patch into the ext4 patch queue.

I changed a printk in ext4_da_writepgaes() from:

                      printk(KERN_EMERG "%s: Not enough credits to flush %ld p
                              wbc->nr_to_write);

to this:

                      printk(KERN_EMERG "ext4_da_writepages: jbd2_start: "
                             "%ld pages, ino %d; err %d\n",
                             wbc->nr_to_write, inode->i_ino, ret)

As it turns out, the primary way this printk triggers is right after a
filesystem is remounted read-only.  My change provides a bit more useful
information.  

I'm not sure whether the read-only remount is failing to force changes
to disk, or the pages are erroneously left dirty; but this should help
us figure out exactly what is going on.  As I said earlier, I don't
think this is the fault of the journal credits patch, but it is exposing
this potential bug in a much more visible way.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux