On Thu, Jul 31, 2008 at 12:47:28PM -0400, Theodore Tso wrote: > On Thu, Jul 31, 2008 at 09:40:59PM +0530, Aneesh Kumar K.V wrote: > > Hi Ted, > > > > I haven't yet looked at whether it is kernel or e2fsck bug. > > But I am having this with the latest patch queue when running > > fsstress. The fsstress have falloc added as a supported operation. > > So it is mostly to do with fallocate. Architecture is x86. > > Part of this is definitely an e2fsck bug, because e2fsck isn't > currently checking the EXT2_EXTENT_FLAGS_UNINIT flag. In line 1715 of > e2fsck/pass1.c: > > start_block = pb->last_block = extent.e_lblk + extent.e_len - 1; > > We shouldn't be setting pb->last_block if this is an unitialized > extent. What I am wondering is that why we didn't observe these errors before. I used to run the same test before and I haven't seen the errors before. I will check the logs again to verify this. Also note that fallocate is called with update i_size option. > > I suspect this is also related though to the issue you raised in the > "e2fsprogs and blocks outside i_size" thread about two weeks ago. So > even after we fix this e2fsck bug, we may still have some fsstress > failures until we decide how to deal with that particular issue. fallocate is called in the test with update i_size. So it should not happen. > > Do you have a quickie program that calls fallocate to preallocate > space for a particular program easily to hand? If not, I can write > one in about 5-10 minutes, but if you have one written already, it'll > save me the effort. Thanks!! -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
