> 4. when checkpointing fails, notify this error to the ext3 layer so > that ext3 don't clear the needs_recovery flag, otherwise the > journaled contents are ignored and cleaned in the recovery phase Mike Snitzer noticed that ext3_mark_recovery_complete() doesn't check checkpointing failure and it clears needs_recovery flag (thanks, Mike!). I need an additional fix. I also found ext3_quota_on() forces checkpointing by journal_flush() but it doesn't check the error. This will appear in 2.6.27-rc1, so I'll send the revised patch set for 2.6.27-rc1 (it may be a separate patch). Thanks, -- Hidehiro Kawai Hitachi, Systems Development Laboratory Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html