Re: [PATCH] e2fsprogs: Fix tst_extents output on bigendian machine.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jul 20, 2008 at 11:07:55PM -0600, Andreas Dilger wrote:
> On Jul 18, 2008  17:35 +0530, Aneesh Kumar wrote:
> >  static void dbg_show_header(struct ext3_extent_header *eh)
> >  {
> >  	printf("header: magic=%x entries=%u max=%u depth=%u generation=%u\n",
> > -	       eh->eh_magic, eh->eh_entries, eh->eh_max, eh->eh_depth,
> > -	       eh->eh_generation);
> > +			ext2fs_le16_to_cpu(eh->eh_magic),
> > +			ext2fs_le16_to_cpu(eh->eh_entries),
> > +			ext2fs_le16_to_cpu(eh->eh_max),
> > +			ext2fs_le16_to_cpu(eh->eh_depth),
> > +			ext2fs_le32_to_cpu(eh->eh_generation));
> 
> Please fix indenting to align this with the '(' on the preceeding line.
> 

I am always confused what is the suggested coding guideline here. I
always use TAB instead of space and use TAB aligned offsets for the
continuation line.


-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux