On Fri, Jul 18, 2008 at 09:19:21PM -0400, Theodore Tso wrote: > On Fri, Jul 18, 2008 at 05:35:40PM +0530, Aneesh Kumar K.V wrote: > > Add type __le16, __le32, and __le64 to indicate that > > the variables need to be byteswaped when using. > > I took out the __le16 types. The artificial types don't really buy us > much (a lot of work would be needed before we could use sparse on > e2fsprogs) and for now just makes it harder to read the header file. > I removed the __le types deliberately. > The reason for me to use __le* types was to explicitly document that these variables need to be accessed through the conversion APIs. In this case I had to search rest of the code to figure out whether all of them need to be accessed via the conversion APIs or not. Getting sparse to run on e2fsprogs can be a long term goal. But more important is to indicate how these variables need to be accessed in the program. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
