On Thu, Jul 17, 2008 at 04:25:49PM +0200, Vegard Nossum wrote: > On Thu, Jul 17, 2008 at 3:57 PM, Josef Bacik <jbacik@xxxxxxxxxx> wrote: > > Can you try this patch out and see if it fixes the problem? I didn't compile > > test it, so you may need to tweak somethings, but it should work. Thanks, > > > > Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxx> > > Nope, seems to be the same problem: > > kjournald starting. Commit interval 5 seconds > EXT3-fs warning: mounting fs with errors, running e2fsck is recommended > EXT3 FS on loop0, internal journal > EXT3-fs: mounted filesystem with ordered data mode. > EXT3-fs error (device loop0): ext3_free_blocks: Freeing blocks in > system zones - Block = 16, count = 1 > EXT3-fs error (device loop0): ext3_free_blocks: Freeing blocks in > system zones - Block = 32, count = 1 > EXT3-fs error (device loop0): ext3_free_blocks: Freeing blocks not in > datazone - block = 262144, count = 1 > BUG: unable to handle kernel NULL pointer dereference at 0000000c > IP: [<c01fd210>] journal_dirty_metadata+0xa0/0x160 > > Full log at http://folk.uio.no/vegardno/linux/log-1216304953.txt > > Ok, this should do it then. Thanks, Josef Index: linux-2.6/fs/ext3/inode.c =================================================================== --- linux-2.6.orig/fs/ext3/inode.c +++ linux-2.6/fs/ext3/inode.c @@ -2023,13 +2023,27 @@ static void ext3_clear_blocks(handle_t * unsigned long count, __le32 *first, __le32 *last) { __le32 *p; + int ret; + if (try_to_extend_transaction(handle, inode)) { if (bh) { BUFFER_TRACE(bh, "call ext3_journal_dirty_metadata"); - ext3_journal_dirty_metadata(handle, bh); + ret = ext3_journal_dirty_metadata(handle, bh); + if (ret) { + ext3_std_error(inode->i_sb, ret); + return; + } } - ext3_mark_inode_dirty(handle, inode); - ext3_journal_test_restart(handle, inode); + ret = ext3_mark_inode_dirty(handle, inode); + if (ret) + return; + + ret = ext3_journal_test_restart(handle, inode); + if (ret) { + ext3_std_error(inode->i_sb, ret); + return; + } + if (bh) { BUFFER_TRACE(bh, "retaking write access"); ext3_journal_get_write_access(handle, bh); Index: linux-2.6/fs/ext3/balloc.c =================================================================== --- linux-2.6.orig/fs/ext3/balloc.c +++ linux-2.6/fs/ext3/balloc.c @@ -498,6 +498,7 @@ void ext3_free_blocks_sb(handle_t *handl ext3_error (sb, "ext3_free_blocks", "Freeing blocks not in datazone - " "block = "E3FSBLK", count = %lu", block, count); + err = -EIO; goto error_return; } @@ -535,6 +536,7 @@ do_more: "Freeing blocks in system zones - " "Block = "E3FSBLK", count = %lu", block, count); + err = -EIO; goto error_return; } -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
