Re: [PATCH 01/15][e2fsprogs] libext2fs: Add 64-bit support to the undo manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 16, 2008 at 01:16:58PM +0200, Goswin von Brederlow wrote:
> Why not this?
> 
> +static errcode_t undo_read_blk64(io_channel channel, blk64_t block,
> +				 int count, void *data);
> 
> libext2fs specifically has blk_t and blk64_t types to represent a
> block. Why not use them? It is less to type and easier to read.

It's an abstraction layer thing.  blk64_t is defined in ext2fs.h, and
the io_managers don't include it.  The I/O managers are a small amount
of code, and it hasn't been worth it to explicitly define a type just
for them in the header file.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux