Re: [PATCH] e2fsprogs : Add stricter checks for blocksize in ext2fs_open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Manish Katiyar wrote:
Below patch adds stricter checks in ext2fs_open() so that we catch bad
block sizes earlier than later.

============================================================================

Signed-off-by: "Manish Katiyar" <mkatiyar@xxxxxxxxx>

---
 lib/ext2fs/openfs.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lib/ext2fs/openfs.c b/lib/ext2fs/openfs.c
index fc54afe..670cc7c 100644
--- a/lib/ext2fs/openfs.c
+++ b/lib/ext2fs/openfs.c
@@ -233,7 +233,9 @@ errcode_t ext2fs_open2(const char *name, const
char *io_options,
 	}
 	
 	fs->blocksize = EXT2_BLOCK_SIZE(fs->super);
-	if (fs->blocksize == 0) {
+	if ((fs->blocksize < EXT2_MIN_BLOCK_SIZE) ||
+	    (fs->blocksize > EXT2_MAX_BLOCK_SIZE) ||
+	    (fs->blocksize % EXT2_MIN_BLOCK_SIZE != 0)) {

It seems to me that this would read more clearly as:

              ((fs->blocksize % EXT2_MIN_BLOCK_SIZE) != 0)) {

   Thanx!

      ps

 		retval = EXT2_ET_CORRUPT_SUPERBLOCK;
 		goto cleanup;
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux