Andreas Dilger wrote: > On Jun 22, 2008 20:18 +0200, FD Cami wrote: >> This patch takes a shot at replacing the direct use of printk(KERN_WARNING) >> in extX by extX_warning. We now get the device number in the warning message : >> "EXT3-fs warning (device hda1): ext3_setup_super: maximal mount count reached, running e2fsck is recommended" >> It also adds the device information on a pair of printk(KERN_ERR) (this was >> first suggested by Kasper two weeks ago). > > The one issue is that KERN_ERR != KERN_WARNING, so these errors might > not be visible on the console, or may not be saved to the syslog. The > other minor difference is that the function name is also printed, and this > makes the error message very long. > > One suggestion is to create a separate macro that passes the KERN_* > flag and __func__ to ext3_console_msg(), and call that from > ext3_warning() and a new ext3_start_error() function. I always found > it annoying to have to specify __func__ as a parameter for every call. I agree and meant to suggest that as well. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
