On Thu, Jun 12, 2008 at 06:17:06PM +0200, Jan Kara wrote: > BTW: XFS, OCFS2 or GFS2 define page_mkwrite() in this manner so they do > return SIGBUS when you run out of space when writing to mmapped hole. So > it's not like this change is introducing completely new behavior... I can > understand that we might not want to change the behavior for ext2 or ext3 > but ext4 is IMO definitely free to choose. Yup, and it's the only sane behaviour, IMO. Letting the application continue to oversubscribe filesystem space and then throwing away the data that can't be written well after the fact (potentially after the application has gone away) is a horrendously bad failure mode. This was one of the main publicised features of ->page_mkwrite() - that it would allow up front detection of ENOSPC conditions during mmap writes. I'm extremely surprised to see that this is being considered undesirable after all this time.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
