On Thu, 2008-06-19 at 13:42 -0400, Theodore Tso wrote: > On Thu, Jun 19, 2008 at 11:41:17AM -0500, Eric Sandeen wrote: > > > > It might be worth runninga "simple" fsx under your kernel too; last time > > I tested fsx it was still happy and it exercises fs ops (including > > truncate) at random... > > > > From what Holger described, it's doubtful that the bug is in the > truncate operation. It sounds like i_size is actually dropping in > size at some pointer long after the file was written. If I had to > guess the value in the inode cache is correct; and perhaps so is the > value on the journal. But somehow, the wrong value is getting written > to disk (remember the jbd layer can keep up to three different > versions of filesystem metadata in memory, because most of the time we > don't block modifications to the filesystem while we are in the middle > of writing a previous commit to disk). So depending on whether the > inode gets redirtied or not, the inconsistency could self-heal, and if > the inode never gets pushed out of memory due to memory pressure, the > problem might not be noticed until the system reboots or the > filesystem is unmounted. > > This is one of the reasons why I'm a bit suspicious that the problem > may lie in the delayed allocation code; changing i_size without first > starting a transaction could lead to this sort of problem, for > example, and the delayed allocation could represent a different code > path where file blocks get allocated and i_size gets changed. > I tend to agree. Without delayed allocation, the in-memory i_size and on-disk i_disksize normally match each other, since we do block allocation at prepare_write/write_begin time, and the i_size update just immedietly around that time. However, with delayed allocation, the in memory i_size is being update around prepare_write/commit_write, but the i_disksize won't updated until later writepage/writepages() time. The window now gets much larger. With writeback mode, since there is no ordering there, I think it's possible the the inode dirty pages have been sync to disk and the inode structure being pushed out of the memory due to memory pressure, before the i_disksize update cached in jbd2 reach to disk. Perhaps that explain the "truncation"? Not sure if this still a issue with the delalloc on new ordered mode, I guess as long as the inode is on jinode list, and that inode can't push out of memeory due to memory pressure since jbd is referencing it, then this seems couldn't happen... > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
