On Wed, Jun 11, 2008 at 11:55:45AM +0800, Shen Feng wrote:
>
> Since md is freed before the do-while checks it,
> it's better to change it to while(1).
This actually isn't a bug, since there is no problem checking a
pointer that has been freed; its only *dereferencing* a pointer which
is bad. That being said, md is never NULL at the end of the loop,
since in the middle of the loop is the only break condition:
if (md == NULL)
break;
So the patch saves a tiny amount of compiled code, but it isn't really
a fix in any way.
That being said, if we're going to make this sort of change, my
preference would be to use the more common C idiom:
while (1) {
...
}
as opposed to
do {
...
} while (1);
The former makes it quite clear that any exit from the loop is not
going to be coming from loop construct itself, but from any embedded
break statements inside the loop construct
Regards,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
