On Wed, Jun 04, 2008 at 09:17:12PM -0600, Andreas Dilger wrote: > On Jun 04, 2008 19:56 -0400, Theodore Ts'o wrote: > > If a journal checksum error is detected, the ext4 filesystem will call > > ext4_error(), and the mount will either continue, become a read-only > > mount, or cause a kernel panic based on the superblock flags > > indicating the user's preference of what to do in case of filesystem > > corruption being detected. > > > > XXX should we simply fail the mount instead in the panic case? > > It does seem that if someone has a bad ext4 root filesystem it would be > easy to get an unusable system. That is why there are no "ext3_error" > or "ext4_error" calls anywhere in ext[34]_fill_super(). They are all > instead "printk(KERN_ERR ...)" and the mount fails. Well, failing the mount or panic'ing as the same result for the root filesystem. It is rude to panic when mounting a corrupt filesystem, especially when you could just fail the mount, though. I'll make that change. > > > diff --git a/scripts/package/Makefile b/scripts/package/Makefile > > index 5e32607..f758b75 100644 > > --- a/scripts/package/Makefile > > +++ b/scripts/package/Makefile > > Not sure what the rest of this patch is... > Some ditritus casued by make-kpkg that slipped in. Oops, sorry about that. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
