when I moved this patch to the beginning of the unstable patch queue,
it didn't apply. When I tried to look at it, my head started
spinning. The patch applied to the wrong function, apparently,
because there is so much code duplication "patch" got confused. I
can't blame it, though, because *I* got confused.
fs/ext4/balloc.c is a complete disaster right now. We have:
ext4_new_blocks_old()
ext4_new_meta_block()
ext4_new_meta_blocks()
ext4_new_blocks()
... and without any comments, it is extremely impenetrable. Someone
needs to document what the heck all of the various functions have to
do with each other, when they get used (i.e., with which mount options).
Why aren't we factoring out the last three into a single function?
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
