Aneesh Kumar K.V wrote:
> On Mon, Jun 02, 2008 at 08:42:24AM -0500, Eric Sandeen wrote:
>> so it's fine... but why are we carrying around a field in the sbi to
>> hold a constant that cannot be changed runtime?
>
> We can tune that via MB_PROC_FOPS(group_prealloc);
MB_PROC_VALUE_WRITE()....
ah, cleverly hidden from cscope with a macro. :)
Ok, so technically then this could be big enough to overflow fe_len:
value = simple_strtol(str, NULL, 0); \
if (value <= 0) \
return -ERANGE; \
sbi->s_mb_##name = value; \
but I guess it's probably not the first thing we need to worry about.
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
