On Sun, Jun 01, 2008 at 04:35:55PM -0700, Mingming Cao wrote: > ext4: delalloc ENOSPC handling core > > From: Mingming cao <cmm@xxxxxxxxxx> > > Core part of delaloc ENOSPC (block reservation.) > data/meta blocks are reserved on write_begin(), and per-inode reserved counters > are updated after block allocation. I am not clear about ext4_da_release_space. Are we accounting for the blocks related to meta-data blocks allocated ? . In ext4_da_get_block_write we get the number of data blocks allocated. and we don't update sbi->s_freeblocks_counter in the block allocator any more. So request for meta-data blocks are not updating the sbi->s_freeblocks_counter. In ext4_da_release_space we update the sbi->s_freeblocks_counter without considering the above. Am I missing something ? -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
