On Sun, Jun 1, 2008 at 11:55 AM, Kari Hurtta <hurtta+gmane@xxxxxxxxxxxx> wrote:
> "Manish Katiyar" <mkatiyar@xxxxxxxxx> writes in
> gmane.linux.file-systems:
>
>> For two unsigned values the check "block+count < block" is always
>> false. Thus the below patch removes that condition.
>>
>> =============================================================
>>
>> Signed-off-by: Manish Katiyar <mkatiyar@xxxxxxxxx>
>>
>> --- a/fs/ext4/balloc.c 2008-05-18 18:07:45.000000000 +0530
>> +++ b/fs/ext4/balloc.c 2008-06-01 00:05:48.000000000 +0530
>> @@ -619,7 +619,6 @@
>> sbi = EXT4_SB(sb);
>> es = sbi->s_es;
>> if (block < le32_to_cpu(es->s_first_data_block) ||
>> - block + count < block ||
>> block + count > ext4_blocks_count(es)) {
>> ext4_error (sb, "ext4_free_blocks",
>> "Freeing blocks not in datazone - "
>>
>>
>> =============================================================
>
> Hmm. Consider situation where block + count > max unsigned value
> mathematically
>
> in that case
> block + count < block
> expression may be true
Yeah.... my bad..... Al Viro pointed it out. Sorry for that
>
>
>> --
>> Thanks & Regards,
>> ********************************************
>> Manish Katiyar ( http://mkatiyar.googlepages.com )
>> 3rd Floor, Fair Winds Block
>> EGL Software Park
>> Off Intermediate Ring Road
>> Bangalore 560071, India
>> ***********************************************
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> / Kari Hurtta
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
