Theodore Tso wrote: > On Thu, May 15, 2008 at 01:17:42PM -0500, Eric Sandeen wrote: >> When called for a given handle, this function will split the >> current node such that half of the node's entries will be moved >> to a new tree block. The parent will then be updated to point >> to the (now smaller) original node as well as the new node. > > This patch looks good. One minor nit; if you're going to define new > functions which are intended to be exported, then they need to be > defined in the ext2fs.h header file --- otherwise, it should be > declared static, to prevent function leakage. Should > ext2fs_node_split() be exported? There doesn't seem to be any reason > *not* to export it, but at the same time, there doesn't seem to be a > good reason to export, either. > > I'd tend to keep it static for now; what do other people think? I'd say static until needed otherwise... an _extent_split might be more useful for a public interface; _node_split is getting awfully low level IMHO. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
