On Wed, May 14, 2008 at 02:07:14PM -0500, Eric Sandeen wrote: > Aneesh Kumar K.V wrote: > > This helps in better debugging of the problem reported. > > ext4_error happens potentially often in some scenarios, and if I chose > errors=continue I'm not sure I'd want to dump this much. > > Would it be worth limiting how often this goes off (maybe just once per fs?) > I actually thought of doing that. But won't rate limiting hide different scenarios in which we can hit the error ? What we would like to know is what system call actually caused the file system error. So that we can try to reproduce the same. Rate limiting would prevent multiple possible errors. As Ted mentioned the right fix would be audit all the ext4_error/warning/abort call sites and add a WARN_ON or WARN_ON_ONCE where ever we find it useful. -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html