On Mon, 12 May 2008 10:43:53 -0400 Theodore Tso <tytso@xxxxxxx> wrote: > On Fri, May 09, 2008 at 11:39:52AM -0500, Jose R. Santos wrote: > > + /*FIXME: Not blk64_t clean */ > > Suggestion, please use "FIXME-64" instead of fixme so it's easier to > clean this up later. Will do. > > int group = ext2fs_group_of_blk(fs, blk); Ops... I missed this one. > Might as well fix this in the initial patch series, earlier --- and > let's *not* make it be an inline function. Yeah, we call > ext2fs_group_of_blk and ext2fs_group_of_ino a fair amount, but #1, on > 32-bit machines, the 64 bit arithmemtic makes the function bigger, and > #2, modern CPU's have greatly reduced the cost of procedure > activations. Will fix it in the series. > - Ted -JRS -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
