On Apr 22, 2008 08:46 -0400, Theodore Ts'o wrote: > Change the way we allocate bitmaps and inode tables if the FLEX_BG > feature is used at mke2fs time. It places calculates a new offset for > bitmaps and inode table base on the number of groups that the user > wishes to pack together using the new "-G" option. Creating a > filesystem with 64 block groups in a flex group can be done by: > > mke2fs -j -I 256 -O flex_bg -G 32 /dev/sdX > > @@ -1638,6 +1654,19 @@ static void PRS(int argc, char *argv[]) > > if (inode_size == 0) > inode_size = get_int_from_profile(fs_types, "inode_size", 0); > + if (!flex_bg_size && (fs_param.s_feature_incompat & > + EXT4_FEATURE_INCOMPAT_FLEX_BG)) > + flex_bg_size = get_int_from_profile(fs_types, "flex_bg_size",8); > + if (flex_bg_size) { > + if (!(fs_param.s_feature_incompat & > + EXT4_FEATURE_INCOMPAT_FLEX_BG)) { > + com_err(program_name, 0, > + _("Flex_bg feature not enabled, so " > + "flex_bg size may not be specified")); > + exit(1); > + } > + fs_param.s_log_groups_per_flex = int_log2(flex_bg_size); > + } Should specifying "-G" enable FLEX_BG, like specifying "-j" or "-J size" will enable HAS_JOURNAL instead of requiring that "-O has_journal" needs to be explicitly given? Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html