On Tue, 2008-04-15 at 18:14 +0200, Jan Kara wrote: > Hi, > > I've ported my patch inversing locking ordering of page_lock and > transaction start to ext4 (on top of ext4 patch queue). Everything except > delayed allocation is converted (the patch is below for interested > readers). I am curious on the following code: ext4_ordered_writepage() + * Note that we don't need to start a transaction unless we're journaling + * data because we should have holes filled from ext4_page_mkwrite(). If + * we are journaling data, we cannot start transaction directly because + * transaction start ranks above page lock so we have to do some magic... Currently you are starting a transaction when the page is locked. What do you plan to do here ? Thanks, Badari -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html