On Mon, 2008-04-07 at 10:43 +0200, Solofo.Ramangalahy@xxxxxxxx wrote: > ext4: update ctime and mtime for truncate with extents. > > From: Solofo Ramangalahy <Solofo.Ramangalahy@xxxxxxxx> > > The recently announced "Linux POSIX file system test suite" > catched a truncate issue when using extents: > mtime and ctime are not updated when truncate is successful. > > This is the single issue catched with "default" ext4 (mkfs and mount > with minimal options). > The testsuite does not report failure with -o noextents. > > With the following patch, all tests of the testsuite passes. > Thanks for the fix. > Signed-off-by: Solofo Ramangalahy <Solofo.Ramangalahy@xxxxxxxx> > > --- > fs/ext4/extents.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6.25-rc8-git5-ext4-52c7a8013ad2c452551a68ff4daab4bacbe28f9d/fs/ext4/extents.c > =================================================================== > --- linux-2.6.25-rc8-git5-ext4-52c7a8013ad2c452551a68ff4daab4bacbe28f9d.orig/fs/ext4/extents.c > +++ linux-2.6.25-rc8-git5-ext4-52c7a8013ad2c452551a68ff4daab4bacbe28f9d/fs/ext4/extents.c > @@ -2947,6 +2947,7 @@ out_stop: > ext4_orphan_del(handle, inode); > > up_write(&EXT4_I(inode)->i_data_sem); > + inode->i_mtime = inode->i_ctime = ext4_current_time(inode); Shouldn't we mark inode dirty after the ctime and and mtime is changed? > ext4_journal_stop(handle); > } > Regards, Mingming > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
