Re: [PATCH, RFC] jbd2: Add commit time into the commit block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 25, 2008 at 11:57:49AM -0700, Mingming Cao wrote:
> On Sat, 2008-03-15 at 20:59 -0400, Theodore Ts'o wrote:
> > Carlo Wood has demonstrated that it's possible to recover deleted
> > files from the journal.  Something that will make this easier is if we
> > can put the time of the commit into commit block.
> > 
> Sounds good. Added to the patch queue after fix the compile error.
> 
> Shouldn't this a JBD2 INCOMPAT feature?

No, because we're just writing some extra data at the end of the
commit record.  There's no imcompatibility implied, since both the
kernel and e2fsck will ignore the extra information.

This is the same reasoning used for why we can add new superblock
fields without needing new compatibility flags, as long as a default
value of 0 does something sane.

						- Ted

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux