On Thu, Mar 20, 2008 at 10:29:50AM -0700, Mingming Cao wrote: > On Thu, 2008-03-20 at 11:09 +0530, Aneesh Kumar K.V wrote: > > > > Could you try the following patch? It updates the i_disksize at the > > > write_end time. > > > > > > > I will test the patch and update you. BTW shouldn't we update > > i_disksize only after actual block got allocated ? > > > > > Hmm...I am not 100% sure but I think we should not to change the > behavior that the on-disk inode size should be updated when write() > returns to user. Right now the in-memory inode size is updated, user > would expecting the same when they run e2fsck, but e2fsck reads inode > size from disk. Pushing the inode i_disksize update at the writeout > (allocation) time will cause the window that i_size is different than > the i_disksize being enlarged quite big. > If we are updating i_disksize during write_end and if we crash before actually allocating the blocks e2fsck will find errors because the inode doesn't really have that many blocks right ? -aneesh -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
