On Sat, 15 Mar 2008 18:49:45 +0000
"Duane Griffin" <duaneg@xxxxxxxxx> wrote:
> Fix a long-standing typo (predating git) that will cause data corruption if a
> journal data block needs unescaping. At the moment the wrong buffer head's data
> is being unescaped.
>
> To test this case mount a filesystem with data=journal, start creating and
> deleting a bunch of files containing only JBD2_MAGIC_NUMBER (0xc03b3998), then
> pull the plug on the device. Without this patch the files will contain zeros
> instead of the correct data after recovery.
>
> Signed-off-by: Duane Griffin <duaneg@xxxxxxxxx>
> ---
> fs/jbd2/recovery.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
> index 1464113..5d0405a 100644
> --- a/fs/jbd2/recovery.c
> +++ b/fs/jbd2/recovery.c
> @@ -535,7 +535,7 @@ static int do_one_pass(journal_t *journal,
> memcpy(nbh->b_data, obh->b_data,
> journal->j_blocksize);
> if (flags & JBD2_FLAG_ESCAPE) {
> - *((__be32 *)bh->b_data) =
> + *((__be32 *)nbh->b_data) =
> cpu_to_be32(JBD2_MAGIC_NUMBER);
> }
>
Thanks. Ted, I'll scoot this into Linus and stable@xxxxxxxxxx tomorrowish.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
