On Mar 15, 2008 20:59 -0400, Theodore Ts'o wrote: > Carlo Wood has demonstrated that it's possible to recover deleted > files from the journal. Something that will make this easier is if we > can put the time of the commit into commit block. > > @@ -170,6 +170,8 @@ struct commit_header { > unsigned char h_chksum_size; > unsigned char h_padding[2]; > __be32 h_chksum[JBD2_CHECKSUM_BYTES]; > + __be32 h_commit_sec; > + __be32 h_commit_nsec; > }; We should probably use a 64-bit seconds field, after we just told someone on #ext4 that it would work until at least 2242 :-). struct commit_header { unsigned char h_chksum_size; unsigned char h_padding[2]; __be32 h_chksum[JBD2_CHECKSUM_BYTES]; __be64 h_commit_sec; __be32 h_commit_nsec; }; Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html