> On Mar 06, 2008 01:59 +0000, Duane Griffin wrote: > > NOTE: For now I'm simply preventing filesystems requiring recovery from being > > remounted read-write. This breaks booting with an uncleanly mounted root > > filesystem! > > I was going to ask about this - not being able to remount rw is a serious > problem because many users have only the root filesystem and this > limitation basically prevents this patch from being landable. > > I'd suggest if the filesystem is going to be remounted read/write that > the journal mapping be discarded and the journal replayed. Depending > on how you do the mapping it may be necessary to invalidate all of the > pages in the cache so that they don't reference the blocks in the journal. Actually, this is nastier than it looks - currently fs, asks ext3_sb_getblk() for block 'a' and it gets buffer head with b_blocknr == 'b' instead. So when remounting you'd have to rewrite these buffers with original block numbers which is not really possible. So I think remapping will have to be solved differently, like providing buffer head with correct b_blocknr but taking care when reading data to it and reading them from elsewhere. Actually, this has to be done anyway because JBD escapes data in the journal and you have to do unescaping when reading data... Honza -- Jan Kara <jack@xxxxxxx> SuSE CR Labs -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
