Re: [RFC][PATCH 0/3] ext4 online defrag (ver 0.7)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Mingming,

Thank you for review. :-)
Next step:
Remove the limit of target file size (now 128MB) in -f mode.
* Past mail concerning -f mode.
http://marc.info/?l=linux-ext4&m=118239067704899&w=4


The old version have many useful high level description, could you
preserve that and add to the change logs in this updated series?
All right.  I'll do so next time.


Dependency:
My patches depend on the multi-block allocation in ext4 patch queue.

mballoc patch already in maintain so this dependency could be removed.
We have to set mballoc mount option for ext4 online defrag,
because it doesn't support single block allocation.
So I think ext4 online defrag depends on mballoc.


Summary of patches:
* These patches are applied on the top of
ext4 git tree(linux-2.6.25-rc3-git4). http://repo.or.cz/r/ext4-patch-queue.git
  And attached files are the updated patches.


I assume the following three patches are diffs against current ext4
patch queue
Exactly.  Sorry for the confusion.


[PATCH 1/3]
 - Interchange the data blocks of the target and
   temporary files in an atomic manner.

[PATCH 2/3]
 - Change the name of functions.
    ext4_ext_xxx -> ext4_defrag_xxx
 - Some cleanups.

[PATCH 3/3] ext4 online defrag command
 - Change the error handling for ext4_iget().
 - Usage is as follows:
   o Put the multiple files closer together.
     # e4defrag -r directory-name
   o Defrag for free space fragmentation.
     # e4defrag -f file-name
   o Defrag for a single file.
     # e4defrag file-name
   o Defrag for all files on ext4.
     # e4defrag device-name

Review and comment are welcome.


Attempted to do so...

The updated patch series could not compile one-by-one, could you rework
the series so that in the future we could able to bi-search the ext4
patch queue?
OK.
I'll make my updated patches to compile one-by-one
then resend them to you.


As a whole, I got compile warning when applied all the
updated patches:(
Oops, I'll fix it. =-O
review comments against the 4 updated kernel patches to follow.
I am confirming your review comments. It will take time a little. :-)
Regards, Akira



--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux