On 08/03/2008, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > That text above was in reply to Andreas comment about checking it in > journal_load. Your fix obviously does make sense althrough doing it > differently as in my reply to your first series would be even better. Sorry if I'm missing something here, but I think the caches do need to be checked. If jbd/ext3 are not modular then even if initialisation fails the journal code may still be called later. I noticed this when testing the failure modes after making my original fix. I have some patches ready to go to address this, which I'll send after this. It turns out journal_load is actually too late to check, though: journal_init_common is called prior to that and will also blow up if the caches are uninitialised. I've taken Andreas' suggestion and attempted to initialise the caches again at that point before failing. I've modified my changes to match the way you suggested doing things in your earlier reply (and thanks for the review, BTW). If you would prefer I'll rework my changes as a separate patch on top. Just let me know. Cheers, Duane. -- "I never could learn to drink that blood and call it wine" - Bob Dylan -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
