On Mar 07, 2008 01:31 +0000, Duane Griffin wrote:
> jbd2 debugfs and stats entries should only be created if cache initialisation
> is successful. At the moment they are being created unconditionally which will
> leave them dangling if cache (and hence module) initialisation fails.
>
> Signed-off-by: Duane Griffin <duaneg@xxxxxxxxx>
Acked-by: Andreas Dilger <adilger@xxxxxxx>
> ---
> fs/jbd2/journal.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 0d8a595..9d48419 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -2315,10 +2315,12 @@ static int __init journal_init(void)
> BUILD_BUG_ON(sizeof(struct journal_superblock_s) != 1024);
>
> ret = journal_init_caches();
> - if (ret != 0)
> + if (ret == 0) {
> + jbd2_create_debugfs_entry();
> + jbd2_create_jbd_stats_proc_entry();
> + } else {
> jbd2_journal_destroy_caches();
> - jbd2_create_debugfs_entry();
> - jbd2_create_jbd_stats_proc_entry();
> + }
> return ret;
> }
>
> --
> 1.5.3.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
