On Mon, Feb 18, 2008 at 12:04:39AM -0700, Andreas Dilger wrote: > On Feb 17, 2008 10:19 +0200, Adrian Bunk wrote: > > This patch contains the following cleanups: > > - make the following needlessly global function static: > > - journal_check_used_features() > > - remove the following unused EXPORT_SYMBOL's: > > - journal_set_features > > - journal_update_superblock > > Nack. I don't object to un-exporting journal_update_superblock(), because > that is pretty internal, but the other functions are intended specifically > for use by code outside of JBD. For example, the journal checksum patch for > ext3/4 uses journal_set_features() to turn on features in the JBD superblock. >... A patch that only unexports journal_update_superblock is below. > Cheers, Andreas cu Adrian <-- snip --> This patch removes the unused EXPORT_SYMBOL(journal_update_superblock). Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx> --- 66cbc7390d66cdeb83a3f81d7ec1ea71d6f6e2c8 foobar diff --git a/fs/jbd/journal.c b/fs/jbd/journal.c index 3943a89..5c2ebb7 100644 --- a/fs/jbd/journal.c +++ b/fs/jbd/journal.c @@ -68,7 +68,6 @@ EXPORT_SYMBOL(journal_set_features); EXPORT_SYMBOL(journal_create); EXPORT_SYMBOL(journal_load); EXPORT_SYMBOL(journal_destroy); -EXPORT_SYMBOL(journal_update_superblock); EXPORT_SYMBOL(journal_abort); EXPORT_SYMBOL(journal_errno); EXPORT_SYMBOL(journal_ack_err); - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
