Re: [PATCH 4/4] ext4: check ext4_journal_get_write_access() errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2008-02-17 at 15:15 +0900, Akinobu Mita wrote:
> Check ext4_journal_get_write_access() errors.
> 
Acked and added to ext4 patch queue

Mingming
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: Stephen Tweedie <sct@xxxxxxxxxx>
> Cc: adilger@xxxxxxxxxxxxx
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Mingming Cao <cmm@xxxxxxxxxx>
> Cc: Theodore Tso <tytso@xxxxxxx>
> ---
>  fs/ext4/namei.c |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> Index: 2.6-rc/fs/ext4/namei.c
> ===================================================================
> --- 2.6-rc.orig/fs/ext4/namei.c
> +++ 2.6-rc/fs/ext4/namei.c
> @@ -57,10 +57,15 @@ static struct buffer_head *ext4_append(h
> 
>  	*block = inode->i_size >> inode->i_sb->s_blocksize_bits;
> 
> -	if ((bh = ext4_bread(handle, inode, *block, 1, err))) {
> +	bh = ext4_bread(handle, inode, *block, 1, err);
> +	if (bh) {
>  		inode->i_size += inode->i_sb->s_blocksize;
>  		EXT4_I(inode)->i_disksize = inode->i_size;
> -		ext4_journal_get_write_access(handle,bh);
> +		*err = ext4_journal_get_write_access(handle, bh);
> +		if (*err) {
> +			brelse(bh);
> +			bh = NULL;
> +		}
>  	}
>  	return bh;
>  }

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux