IF we fail fallocate don't call ext4_error. Also don't hide errors from ext4_get_blocks_wrap Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@xxxxxxxxxxxxxxxxxx> --- fs/ext4/extents.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index 5b22f71..bb01ac6 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -2653,13 +2653,14 @@ retry: ret = ext4_get_blocks_wrap(handle, inode, block, max_blocks, &map_bh, EXT4_CREATE_UNINITIALIZED_EXT, 0); - WARN_ON(ret <= 0); if (ret <= 0) { +#ifdef EXT4FS_DEBUG + WARN_ON(ret <= 0); ext4_error(inode->i_sb, "ext4_fallocate", "ext4_ext_get_blocks returned error: " "inode#%lu, block=%u, max_blocks=%lu", inode->i_ino, block, max_blocks); - ret = -EIO; +#endif ext4_mark_inode_dirty(handle, inode); ret2 = ext4_journal_stop(handle); break; -- 1.5.4.1.97.g40aab-dirty - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html