On Fri, 2008-02-08 at 10:25 -0800, Mingming Cao wrote: > On Fri, 2008-02-08 at 10:55 -0600, Eric Sandeen wrote: > > Mingming Cao wrote: > > > > > printk could be removed...so as long as it builds fine. I had looked at > > > the history yesterday and find this fix > > > http://lists.openwall.net/linux-ext4/2007/10/10/2 > > > so I was under impression that the ifdefs was added to fix compile > > > issue. I did not look more closely. Maybe that's not a issue any more. > > > > I guess I should look into it. For now let's just drop the #ifdef > > removal, it's not related anyway. > > > > Would you like me to send a fresh patch? > > > ah...not necessary, I can edit the patch when merge it to the queue. > Yes we could deal with the ifdef in a separate patch, maybe something > like suggested by Shaggy. The ifdef thing is sounding like a more global thing that could clean up code elsewhere, so it's probably more of a kernel-janitors type thing. I don't know if anyone wants to pursue it. It's not a priority for me. Shaggy -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
