On Wed, Jan 02, 2008 at 03:16:59PM -0500, Josef Bacik wrote: > Hello, > > People wishing to make live usb disks and such are looking for a way > to get the minimum resize size for an ext fs in blocks so that they > can just resize their image to that size and do with it what they > will. This patch adds that functionality, just pass -m option and > it calculates the minimum number of blocks the fs can be resized to. Three comments. Instead of using a new option, why not simply let resize2fs check to see if the optional parameter is something like "min" or "0"? Secondly, I'd suggest factoring out the calculation of the minimal size into a separate function. Finally, please don't fix whitespace issues, as it makes it harder for me to merge between the "maint" and "master" development lines. What I plan to do is to do a massive fixup of trailing whitespace before the next major (1.41) release of e2fsprogs. Any new lines added by patches should not introduce any new trailing whitespace, of course. Thanks! - Ted - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
